linux-kernel - Re: [PATCH] Remove pty_ops_bsd and pty_bsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29895.1254306000@redhat.com>
Date:	Wed, 30 Sep 2009 11:20:00 +0100
From:	David Howells <dhowells@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	dhowells@...hat.com, akpm@...ux-foundation.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used

Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> So I do wonder whether the right thing to do would not be to simple remove 
> the whole pty_ops_bsd code entirely. Or maybe mode the trivial TIOCSPTLCK 
> into the generic tty ioctl handling, and just make it test for 
> "driver->subtype == PTY_TYPE_MASTER" - and at least get rid of this subtle 
> thing that was broken for over a year without anybody noticing..

Also, does it matter if someone issues TIOCGPTN on a legacy pty master?  There
is a number in tty->index that can be returned.  If it can, then
pty_bsd_ioctl() can be merged with pty_unix98_ioctl(), and possibly both
ioctls can be given to the generic tty ioctl handling with the condition that
driver->subtype == PTY_TYPE_MASTER.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/