linux-kernel - Re: [PATCH 1/5] checkpatch: fix false errors due to macro concatenation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254406804.18167.90.camel@desktop>
Date:	Thu, 01 Oct 2009 07:20:04 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] checkpatch: fix false errors due to macro
 concatenation

On Wed, 2009-09-30 at 18:46 +0100, Andy Whitcroft wrote:

> Ok, just removing these characters in the conversion changes the
> relative length of the converted form and breaks position reporting for
> other checks, for instance if I stupidly convert the ## to # so its
> still invalid we then get this:
> 
> +	entry = (struct ftrace_raw_##call *)raw_data; \
> 
> It is probabally more correct to include this <ident> ## <ident> form in
> the definition of an identifier.  I've respun this patch to do just that
> and it looks like its working as we would hope.

It could just become "__" something that would match on an ident and
keep the spacing the same.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/