[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1254407172.18167.96.camel@desktop>
Date: Thu, 01 Oct 2009 07:26:12 -0700
From: Daniel Walker <dwalker@...o99.com>
To: Andy Whitcroft <apw@...onical.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] checkpatch: fix __attribute__ matching
On Wed, 2009-09-30 at 18:46 +0100, Andy Whitcroft wrote:
> The problem with the __attribute__ match is that it is impossible to
> sensibly write as a regular-expression as it has nested round brackets
> within it. I do wonder why we care what is before the equals. I
> suspect that any assignment ='s followed by a newline, followed by a {
> is wrong. There are few places that a { is right on the next line.
Yeah, I was thinking about that also .. I though there might be some
"= {" situation I wasn't thinking of tho.
> I'll try that one out and see if it fires any false positives. Its
> passing my tests here.
>
> Could you see if the version at the url below works better for you:
>
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
I'm wondering about your release cycle .. You seem to be selectively
sending patches to Andrew ? Have you considered putting all your changes
into Linux-Next for instance then just keep up with the merge-window
cycle ? Either that or send everything to Andrew.. Either way, you would
have all the changes getting tested, instead of something like above
where is "testing" or a version number at an obscure url location..
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists