linux-kernel - [PATCH] drivers/char/pcmcia/synclink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Oct 2009 19:37:21 +0900
From:	lenrek@...com
To:	linux-kernel@...r.kernel.org
Cc:	lenrek@...com
Subject: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

I found the counterpart of function mgslpc_wait_until_sent
in drivers/char/synclinkmp.c (wait_until_sent) is modified to
issue (un)lock_kernel.  This patch does the same modification.

However, I'm afraid similar modifications are necessary further on  
functions
mgslpc_ioctl and mgslpc_write_room.

--- linux-2.6.31.1/drivers/char/pcmcia/synclink_cs.c	2009-10-02  
17:01:23.000000000 +0900
+++ linux/drivers/char/pcmcia/synclink_cs.c	2009-10-02  
17:23:59.000000000 +0900
@@ -2442,6 +2442,8 @@
  	if (!info )
  		return;

+	lock_kernel();
+
  	if (debug_level >= DEBUG_LEVEL_INFO)
  		printk("%s(%d):mgslpc_wait_until_sent(%s) entry\n",
  			 __FILE__,__LINE__, info->device_name );
@@ -2490,6 +2492,7 @@
  	}

  exit:
+	unlock_kernel();
  	if (debug_level >= DEBUG_LEVEL_INFO)
  		printk("%s(%d):mgslpc_wait_until_sent(%s) exit\n",
  			 __FILE__,__LINE__, info->device_name );

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/