linux-kernel - Re: [PATCH] drivers/char/pcmcia/synclink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091002124945.1814a2c3@lxorguk.ukuu.org.uk>
Date:	Fri, 2 Oct 2009 12:49:45 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	lenrek@...com
Cc:	linux-kernel@...r.kernel.org, lenrek@...com
Subject: Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

On Fri, 02 Oct 2009 19:37:21 +0900
lenrek@...com wrote:

> I found the counterpart of function mgslpc_wait_until_sent
> in drivers/char/synclinkmp.c (wait_until_sent) is modified to
> issue (un)lock_kernel.  This patch does the same modification.
> 
> However, I'm afraid similar modifications are necessary further on  
> functions
> mgslpc_ioctl and mgslpc_write_room.

The push down work normally eliminated BKL calls that were demonstrably
not needed and left it in anywhere that needed thought. Do those
functions still really need the BKL ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/