linux-kernel - Re: [PATCH] drivers/char/pcmcia/synclink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AC5FE11.9060500@microgate.com>
Date:	Fri, 02 Oct 2009 08:20:17 -0500
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	lenrek@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

Alan Cox wrote:
> On Fri, 02 Oct 2009 19:37:21 +0900
> lenrek@...com wrote:
> 
>> I found the counterpart of function mgslpc_wait_until_sent
>> in drivers/char/synclinkmp.c (wait_until_sent) is modified to
>> issue (un)lock_kernel.  This patch does the same modification.
>>
>> However, I'm afraid similar modifications are necessary further on  
>> functions
>> mgslpc_ioctl and mgslpc_write_room.
> 
> The push down work normally eliminated BKL calls that were demonstrably
> not needed and left it in anywhere that needed thought. Do those
> functions still really need the BKL ?

No, these functions use a device specific spinlock (info->lock)
when needed. Not even mgslpc_wait_until_sent needs BKL.

-- 
Paul Fulghum
MicroGate Systems, Ltd.
=Customer Driven, by Design=
(800)444-1982
(512)345-7791 (Direct)
(512)343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/