linux-kernel - Re: [PATCH] panic: call bust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530910020507u43413e6aj2388771e7caeed01@mail.gmail.com>
Date:	Fri, 2 Oct 2009 14:07:55 +0200
From:	Frédéric Weisbecker <fweisbec@...il.com>
To:	Aaro Koskinen <aaro.koskinen@...ia.com>
Cc:	mingo@...e.hu, akpm@...ux-foundation.org, arjan@...ux.intel.com,
	ak@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] panic: call bust_spinlocks(0) before dying

2009/10/2 Aaro Koskinen <aaro.koskinen@...ia.com>:
> Commit ffd71da4e3f323b7673b061e6f7e0d0c12dc2b49 moved bust_spinlocks(0)
> to the end of the function, which in practice is never reached. As a
> result console_unblank() is not called, and on some systems the user
> may not see the panic message.


Indeed.


> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>
> ---
>  kernel/panic.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index bcdef26..96b45d0 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)
>
>        atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
>
> +       bust_spinlocks(0);
> +

And it looks like the right place to do that. The rest that is going
to be displayed
is messages about countdown before reboot. The most important messages
have been printk'ed already.

Reviewed-by: Frederic Weisbecker <fweisbec@...il.com>


>        if (!panic_blink)
>                panic_blink = no_blink;
>
> @@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
>                mdelay(1);
>                i++;
>        }
> -       bust_spinlocks(0);
>  }
>
>  EXPORT_SYMBOL(panic);
> --
> 1.5.4.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/