linux-kernel - [tip:core/urgent] panic: Fix panic message visibility by calling bust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-1f6dff52344945f665524f547a27f3cc0388cb90@git.kernel.org>
Date:	Fri, 2 Oct 2009 12:34:04 GMT
From:	tip-bot for Aaro Koskinen <aaro.koskinen@...ia.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	fweisbec@...il.com, aaro.koskinen@...ia.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:core/urgent] panic: Fix panic message visibility by calling bust_spinlocks(0) before dying

Commit-ID:  1f6dff52344945f665524f547a27f3cc0388cb90
Gitweb:     http://git.kernel.org/tip/1f6dff52344945f665524f547a27f3cc0388cb90
Author:     Aaro Koskinen <aaro.koskinen@...ia.com>
AuthorDate: Fri, 2 Oct 2009 14:41:20 +0300
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 2 Oct 2009 14:23:12 +0200

panic: Fix panic message visibility by calling bust_spinlocks(0) before dying

Commit ffd71da4e3f ("panic: decrease oops_in_progress only after
having done the panic") moved bust_spinlocks(0) to the end of the
function, which in practice is never reached.

As a result console_unblank() is not called, and on some systems
the user may not see the panic message.

Move it back up to before the unblanking.

Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>
Reviewed-by: Frederic Weisbecker <fweisbec@...il.com>
LKML-Reference: <1254483680-25578-1-git-send-email-aaro.koskinen@...ia.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/panic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 512ab73..bc4dcb6 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)
 
 	atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
 
+	bust_spinlocks(0);
+
 	if (!panic_blink)
 		panic_blink = no_blink;
 
@@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
 		mdelay(1);
 		i++;
 	}
-	bust_spinlocks(0);
 }
 
 EXPORT_SYMBOL(panic);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/