linux-kernel - Re: [PATCH] USB: ftdi_sio: Remove tty->low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091003173324.315855ac@lxorguk.ukuu.org.uk>
Date:	Sat, 3 Oct 2009 17:33:24 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Johan Hovold <jhovold@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Michael Trimarchi <trimarchi@...dalf.sssup.it>,
	Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: ftdi_sio: Remove tty->low_latency.

> Of course -- the "with low latency set" part fell out (or, was implicit
> ;-) ). Your patch, however, still has low_latency set when it calls
> tty_flip_buffer_push and that's the problem.

I don't think it does - I removed all the low latency setting.

> How about unifying them to all use a single flag field (with two flags)
> in usb_serial_port?

May make sense.

> 
> > > +	 * The per character mucking around with sysrq path it too slow, so
> > > +	 * shortcircuit it in the 99.9999999% of cases where the USB serial is
> > > +	 * not a console anyway.
> > > +	 */
> > > +	ch = packet + 2;
> > > +	len -= 2;
> > > +	if (!port->console || !port->sysrq)
> > 
> > You need && flag == TTY_NORMAL ?
> 
> You tell me. :-) Are we interested in them unless port->console is set?

Yes - we don;t care about the sysrq but we care about error characters
being reported ot the line discipline properly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/