linux-kernel - Re: [PATCH] USB: ftdi_sio: Remove tty->low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091003164625.GB12952@localhost>
Date:	Sat, 3 Oct 2009 18:46:25 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Johan Hovold <jhovold@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Michael Trimarchi <trimarchi@...dalf.sssup.it>,
	Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: ftdi_sio: Remove tty->low_latency.

On Sat, Oct 03, 2009 at 05:33:24PM +0100, Alan Cox wrote:
> > Of course -- the "with low latency set" part fell out (or, was implicit
> > ;-) ). Your patch, however, still has low_latency set when it calls
> > tty_flip_buffer_push and that's the problem.
> 
> I don't think it does - I removed all the low latency setting.

It's still in the patch you posted (and ASYNC_LOW_LATENCY is left
unmodifed, that is set, by your patch):

@@ -1700,9 +1697,6 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
        spin_lock_irqsave(&priv->tx_lock, flags);
        priv->tx_bytes = 0;
        spin_unlock_irqrestore(&priv->tx_lock, flags);
-       spin_lock_irqsave(&priv->rx_lock, flags);
-       priv->rx_bytes = 0;
-       spin_unlock_irqrestore(&priv->rx_lock, flags);

        if (tty)
                tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
@@ -1730,7 +1724,6 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
        spin_unlock_irqrestore(&priv->rx_lock, flags);

        /* Start reading from the device */
-       priv->rx_processed = 0;
        usb_fill_bulk_urb(port->read_urb, dev,
                        usb_rcvbulkpipe(dev, port->bulk_in_endpointAddress),
                        port->read_urb->transfer_buffer,


But nevermind, we agree it should go. :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/