linux-kernel - Re: [PATCH] percpu: fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AC956D2.4010301@oracle.com>
Date:	Sun, 04 Oct 2009 19:15:46 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] percpu: fix compile warnings

Tejun Heo wrote:
> Fix the following two compile warnings which show up on i386.
> 
> mm/percpu.c:1873: warning: comparison of distinct pointer types lacks a cast
> mm/percpu.c:1879: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'size_t'
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
> This patch has been committed to percpu#for-next.  Thanks.
> 
>  mm/percpu.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/percpu.c b/mm/percpu.c
> index e4e08b8..ec158bb 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1868,13 +1868,14 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, ssize_t dyn_size,
>  	max_distance = 0;
>  	for (group = 0; group < ai->nr_groups; group++) {
>  		ai->groups[group].base_offset = areas[group] - base;
> -		max_distance = max(max_distance, ai->groups[group].base_offset);
> +		max_distance = max_t(size_t, max_distance,
> +				     ai->groups[group].base_offset);
>  	}
>  	max_distance += ai->unit_size;
>  
>  	/* warn if maximum distance is further than 75% of vmalloc space */
>  	if (max_distance > (VMALLOC_END - VMALLOC_START) * 3 / 4) {
> -		pr_warning("PERCPU: max_distance=0x%lx too large for vmalloc "
> +		pr_warning("PERCPU: max_distance=0x%zx too large for vmalloc "
>  			   "space 0x%lx\n",
>  			   max_distance, VMALLOC_END - VMALLOC_START);
>  #ifdef CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/