linux-kernel - Re: [PATCH v2] firmware: only allow EDD on x86/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0910060021q6b76d277q9f6761bb1fd49bb@mail.gmail.com>
Date:	Tue, 6 Oct 2009 03:21:20 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] firmware: only allow EDD on x86/x86_64

On Tue, Oct 6, 2009 at 03:07, Takashi Iwai wrote:
> At Tue,  6 Oct 2009 01:57:07 -0400,
>> Rather than have the EDD depend on !ia64 (and assuming that only ia64,
>> x86, x86_64 will be including this Kconfig), have EDD depend on the only
>> arches which can support this code.  This should allow all other arches
>> to cleanly include the firmware Kconfig.
>>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>> ---
>> v2
>>       - send out the right file this time
>>
>>  drivers/firmware/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>> index ebb9e51..7fff33f 100644
>> --- a/drivers/firmware/Kconfig
>> +++ b/drivers/firmware/Kconfig
>> @@ -7,7 +7,7 @@ menu "Firmware Drivers"
>>
>>  config EDD
>>       tristate "BIOS Enhanced Disk Drive calls determine boot disk"
>> -     depends on !IA64
>> +     depends on (X86_64 || X86_32)
>
> How about "depends on X86" ?

i merely copied the string as seen in FIRMWARE_MEMMAP ... i assumed
that was the way to go.  if simply using x86 works, then i can change
it to that.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/