linux-kernel - [PATCH] ixj: Fix test in ixj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Oct 2009 17:47:16 +0200
From:	Roel Kluin <roel.kluin@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] ixj: Fix test in ixj_selfprobe()

Not makes it a bool before the comparison.

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
Was below intended?

diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
index 40de151..da3c9a0 100644
--- a/drivers/telephony/ixj.c
+++ b/drivers/telephony/ixj.c
@@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
 	} else {
 		switch (j->cardtype) {
 		case QTI_PHONEJACK:
-			if (!j->dsp.low != 0x20) {
+			if (j->dsp.low != 0x20) {
 				j->dsp.high = 0x80;
 				j->dsp.low = 0x20;
 				ixj_WriteDSPCommand(0x3800, j);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/