linux-kernel - Re: [PATCH] ixj: Fix test in ixj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091013165403.7e553eb7.akpm@linux-foundation.org>
Date:	Tue, 13 Oct 2009 16:54:03 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ixj: Fix test in ixj_selfprobe()

On Tue, 06 Oct 2009 17:47:16 +0200
Roel Kluin <roel.kluin@...il.com> wrote:

> Not makes it a bool before the comparison.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Was below intended?
> 
> diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
> index 40de151..da3c9a0 100644
> --- a/drivers/telephony/ixj.c
> +++ b/drivers/telephony/ixj.c
> @@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
>  	} else {
>  		switch (j->cardtype) {
>  		case QTI_PHONEJACK:
> -			if (!j->dsp.low != 0x20) {
> +			if (j->dsp.low != 0x20) {
>  				j->dsp.high = 0x80;
>  				j->dsp.low = 0x20;
>  				ixj_WriteDSPCommand(0x3800, j);

gee, I can't tell.  Presumably it'd be safer to just delete the test -
it's a no-op at present and that code is well-tested, lol.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/