linux-kernel - Re: [PATCH] Integrating SEP Driver with RAR Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091006213142.GC21996@kroah.com>
Date:	Tue, 6 Oct 2009 14:31:42 -0700
From:	Greg KH <greg@...ah.com>
To:	Mark Allyn <mark.a.allyn@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	charles.f.johnson@...el.com
Subject: Re: [PATCH] Integrating SEP Driver with RAR Driver

On Tue, Oct 06, 2009 at 01:46:17PM -0700, Mark Allyn wrote:
> SEP stands for Security Processor; a dedicated processor
> that does encryption, decryption, key management, and
> secure storage.
> 
> RAR stands for Restricted Access Region; this is memory
> aboard the MID platform that is restricted (via hardware)
> from access by software running on the x86 processor. 
> Dedicated 'smart' peripherals such as sound, video, and
> encryption can access these regions of memory. They are here
> to help protect copyrighted midia from being illegally copied.
> 
> This is upstream revision 4 of the SEP driver.
> 
> This is a patch referenced from the linux-next repository
> as pulled on October 6, 2009; from the following URL:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
> 
> This is a modified SEP driver to include integration with
> the RAR driver
> 
> The SEP uses a region of restricted memory to hold its own
> firmware; protecting that firmware and it's operation by
> snooping via the x86 software.
> 
> Please be aware that this patch does not contain any encryption
> algorithm. It only transports data to and from user space
> applications to the security processor.

Also, the patch contains _numerous_ checkpatch.pl warnings and errors.
Why are you submitting new changes to an existing staging driver with
more errors that others will need to later clean up?  That seems quite
self-defeating...

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/