linux-kernel - Re: [PATCH] Integrating SEP Driver with RAR Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091006231955.003932b7@lxorguk.ukuu.org.uk>
Date:	Tue, 6 Oct 2009 23:19:55 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Allyn <mark.a.allyn@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com, greg@...ah.com,
	charles.f.johnson@...el.com, Mark Allyn <mark.a.allyn@...el.com>
Subject: Re: [PATCH] Integrating SEP Driver with RAR Driver

> +#define SEP_IOCTLSETCALLERID                   _IO(SEP_IOC_MAGIC_NUMBER , 33)

_IOR _IOW etc... I pointed this out before and it's not fixed


>  struct sep_driver_realloc_cache_resident_t {
> -	/* new cache address */
> -	u64 new_cache_addr;
> -	/* new resident address */
> -	u64 new_resident_addr;
> -	/* new resident address */
> -	u64  new_shared_area_addr;
> -	/* new base address */
> -	u64 new_base_addr;
> -};
> +  /* base address */
> +  unsigned long   base_addr;

and the ioctls still need to be fixed for 32/64bit


> +/* debug macro with 3 paramaters */
> +#define DEBUG_PRINT_3(DEBUG_LEVEL, info, param1, param2, param3) \
> +do { \
> +	if (DEBUG_LEVEL & sepDebug) \
> +		printk(KERN_WARNING info , param1, param2 , param3); \
> +} while (0)

And the debug helpers are a step back

Sorry but this is basically undoing a lot of cleanup that was needed.


To put it mildly this needs a lot of further discussion before anything
goes into the code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/