linux-kernel - RE: Xilinx SYSACE driver and 8-bit attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51ada07b-493e-4552-b79b-7a4044ae1b4c@VA3EHSMHS028.ehs.local>
Date:	Wed, 7 Oct 2009 09:18:40 -0700
From:	Stephen Neuendorffer <stephen.neuendorffer@...inx.com>
To:	"Grant Likely" <grant.likely@...retlab.ca>,
	"John Linn" <linnj@...inx.com>
CC:	"David DeBonis" <ddeboni@...inx.com>,
	"devicetree-discuss" <devicetree-discuss@...ts.ozlabs.org>,
	"Linux Kernel list" <linux-kernel@...r.kernel.org>,
	"Michal Simek" <michal.simek@...alogix.com>,
	"John Linn" <linnj@...inx.com>,
	"John Williams" <john.williams@...alogix.com>
Subject: RE: Xilinx SYSACE driver and 8-bit attachment



> -----Original Message-----
> From: devicetree-discuss-bounces+stephen.neuendorffer=xilinx.com@...ts.ozlabs.org [mailto:devicetree-
> discuss-bounces+stephen.neuendorffer=xilinx.com@...ts.ozlabs.org] On Behalf Of Grant Likely
> Sent: Wednesday, October 07, 2009 7:53 AM
> To: John Linn
> Cc: David DeBonis; Stephen Neuendorffer; devicetree-discuss; Linux Kernel list; Michal Simek; John
> Linn; John Williams
> Subject: Re: Xilinx SYSACE driver and 8-bit attachment
> 
> On Wed, Oct 7, 2009 at 8:42 AM, John Linn <John.Linn@...inx.com> wrote:
> >> -----Original Message-----
> >> From: John Linn
> >> Sent: Wednesday, October 07, 2009 8:24 AM
> >> To: 'Grant Likely'; John Williams
> >> Cc: Linux Kernel list; Michal Simek; David DeBonis; Stephen Neuendorffer; devicetree-discuss
> >> Subject: RE: Xilinx SYSACE driver and 8-bit attachment
> >>
> >> I'll look to see if something has changed.  It's not clear to me if it has ever been right.
> >>
> >> It look like we normally use 16 bit mode as that's how BSB generates the system by default.
> >>
> >> Thanks,
> >> John
> >>
> >> > -----Original Message-----
> >> > From: glikely@...retlab.ca [mailto:glikely@...retlab.ca] On Behalf Of Grant Likely
> >> > Sent: Wednesday, October 07, 2009 7:35 AM
> >> > To: John Williams
> >> > Cc: Linux Kernel list; Michal Simek; John Linn; David DeBonis; Stephen Neuendorffer; devicetree-
> >> > discuss
> >> > Subject: Re: Xilinx SYSACE driver and 8-bit attachment
> >> >
> >> > [Added devicetree-discuss to cc: list]
> >> >
> >> > On Wed, Oct 7, 2009 at 1:13 AM, John Williams
> >> > <john.williams@...alogix.com> wrote:
> >> > > Hi Grant (it's your driver :) and David D ( and your DTS generator :)
> >> > [...]
> >> > > if (of_find_property(op->node, "8-bit", NULL))
> >> > [...]
> >> > > doesn't match the properties generated by Xilinx's device tree generator:
> >> > [...]
> >> > >                         xlnx,mem-width = <0x8>;
> >
> > Do you know if the 8 bit mode was ever tested with the "8-bit" property in the tree?
> >
> > I don't see anything in the device tree generator history to say we ever did that "8-bit", but
> maybe I'm missing something.
> >
> > We are just generating the parameters from the h/w and the memory width is it.  We can always put
> something in there special, but it seems silly if it was never used anyway.
> 
> Don't forget that Virtex and Microblaze are not the only users of this
> driver.   There is a AMCC 440 board which uses the sysace as a CF
> adapter.  8-bit was definitely tested and is in use.

In this case, I'm pretty sure this tag was never automatically generated by the DTS generator.
Personally, I think it's bad practice to always assume that the device tree generator should be modified to match what a Linux driver is expecting, however given the precedence in this case,
I agree that it might be reasonable to put a special case in to generate this.

Steve
 

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/