linux-kernel - Re: [PATCH 1/7] printk: clean up return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ACCC0E3.8050404@tuffmail.co.uk>
Date:	Wed, 07 Oct 2009 17:25:07 +0100
From:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	mingo@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] printk: clean up return value

Linus Torvalds wrote:
> Hmm. I kind of agree with this, but at the same time I suspect that no 
> caller should ever care about the loglevel characters (since they won't be 
> _shown_), so your change still doesn't make it return a sensible value.
>
> So I get the feeling that you should also add a
>
> 	message_len -= 3;
>
> to the case where we peel off the "<.>" loglevel part at the head of the 
> string. No?
>   

The value is only really sensible for partial printk()s... except that
they're supposed to be prefixed with KERN_CONT.  So yes, good point.

> Or we could just change it to 'void'. As Joe Perches says, nobody really 
> cares deeply enough for this to generally even matter.
>   

That involves more work, which explains why I shied away from it :-). 
Ok, I'll do it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/