linux-kernel - Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091007162839.GA5903@nowhere>
Date:	Wed, 7 Oct 2009 18:28:42 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	rostedt@...dmis.org, Ingo Molnar <mingo@...e.hu>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ibm.com>,
	"Frank Ch. Eigler" <fche@...hat.com>
Subject: Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special
	variables syntax

On Tue, Oct 06, 2009 at 09:13:50PM -0400, Masami Hiramatsu wrote:
> Frederic Weisbecker wrote:
> > On Tue, Oct 06, 2009 at 10:23:50AM -0400, Masami Hiramatsu wrote:
> >> OK, so here are syntax ideas
> >>
> >> * current syntax
> >> <Ftrace>
> >> - $sp_var
> >> - %regs
> >> - @symbol
> >> <Perf>
> >> - local_var
> > 
> > 
> > This one looks good.
> > And why not turning @symbol into symbol?
> > Then it's up to perf probe to find the right
> > target.
> 
> Hmm, one big reason for separating local_vars
> and others is that I'd like to check whether
> perf-probe needs debuginfo or not.
> If there is no local_vars, we don't need to
> parse debuginfo. Sometimes, it is useful just
> for setting up probe points.
> 
> > And @ can be used for raw addresses?
> 
> Yeah, but @ can be shared with symbols and raw addresses.
> If the first char is digit, it's not a symbol.:-)
> 
> And also, @symbol actually has its syntax rule.:-)
> its real syntax is:
> @[MODULE:]SYMBOL[+OFFSET]
> or
> @ADDRESS (0xNN (base 16) or NN (base 10))
> 
> Perhaps, since perf-probe has another syntax rule,
> I don't want to confuse users. :-P
> 
> Thank you,
> 

Ok let's pick @ for symbols then.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/