linux-kernel - Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ACD1C3D.3030506@oracle.com>
Date:	Wed, 07 Oct 2009 15:54:53 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Johannes Berg <johannes@...solutions.net>
CC:	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE

Johannes Berg wrote:
> On Wed, 2009-10-07 at 14:55 -0700, Randy Dunlap wrote:
>> John W. Linville wrote:
>>> Should prevent this build error reported by Randy...
>>>
>>> net/wireless/wext-priv.c:206: error: implicit declaration of function 'call_commit_handler'
>>> make[3]: *** [net/wireless/wext-priv.o] Error 1
>>>
>>> Reported-by: Randy Dunlap <randy.dunlap@...cle.com>
>>> Signed-off-by: John W. Linville <linville@...driver.com>
>> Sorry, it did not work for me.
> 
>> linux-next-20091007/net/wireless/wext-priv.c:206: error: implicit declaration of function 'call_commit_handler'
>> make[3]: *** [net/wireless/wext-priv.o] Error 1
>>
>> Drivers like hostap and orinoco (hermes) select WEXT_PRIV regardless
>> of the setting of WEXT_CORE.  oh, and staging/ drivers do that also.
> 
> But they also select WIRELESS_EXT, which should cause WEXT_CORE to be
> turned on. Is it possible that is failing?

# CONFIG_WIRELESS is not set
CONFIG_WIRELESS_EXT=y
CONFIG_WEXT_SPY=y
CONFIG_WEXT_PRIV=y

WEXT_CORE is not enabled.  I haven't found the culprit, but I suspect "select".

but what in WIRELESS_EXT would also cause WEXT_CORE to be enabled?

~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/