linux-kernel - Re: Samsung Backlight Patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091007225828.GA7892@kroah.com>
Date:	Wed, 7 Oct 2009 15:58:28 -0700
From:	Greg KH <greg@...ah.com>
To:	Mike Lothian <mike@...eburn.co.uk>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Matthias Hopf <mhopf@...e.de>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: Samsung Backlight Patch

On Wed, Oct 07, 2009 at 10:31:44PM +0100, Mike Lothian wrote:
> 2009/10/7 Greg KH <greg@...ah.com>:
> > On Wed, Oct 07, 2009 at 10:14:37PM +0100, Mike Lothian wrote:
> >> Hi
> >>
> >> I was hoping the following patch could be included in 2.6.32 so it
> >> would hopefully end up in the next round of distros
> >>
> >> It adds backlight support for some Samsung laptops
> >
> > You seem to have lost the original authorship of this patch, and not
> > included your signed-off-by for it.
> >
> > Which means it can't be applied :(
> >
> > thanks,
> >
> > greg k-h
> >
> 
> It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman
> <gregkh@...e.de>"); at the bottom
> 
> I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
	From: Greg Kroah-Hartman <gregkh@...e.de>

as the first line.

> Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I
would like my authorship to remain.  Someone needs to sign off on it...

> I think there's a few other models that can be added to this patch too

I do too.

Note, if you look at the git tree I have for the driver, it is totally
rewritten to not use a structure, and instead, use offsets properly.
But it removed support for your laptop, which is not what you probably
want :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/