linux-kernel - Re: next-20091007 - comedi driver build breaks on S390x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091008105528.55616624@mschwide.boeblingen.de.ibm.com>
Date:	Thu, 8 Oct 2009 10:55:28 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Greg KH <gregkh@...e.de>
Cc:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	devel@...verdev.osuosl.org, heiko.carstens@...ibm.com,
	linux-s390@...r.kernel.org
Subject: Re: next-20091007 - comedi driver build breaks on S390x

On Wed, 7 Oct 2009 10:27:15 -0700
Greg KH <gregkh@...e.de> wrote:

> On Wed, Oct 07, 2009 at 05:34:15PM +0200, Martin Schwidefsky wrote:
> > On Wed, 7 Oct 2009 06:07:44 -0700
> > Greg KH <gregkh@...e.de> wrote:
> > 
> > > On Wed, Oct 07, 2009 at 04:24:58PM +0530, Kamalesh Babulal wrote:
> > > > Hi Greg,
> > > > 
> > > > 	next-20091007 randconfig build breaks on s390x with build error
> > > > 
> > > > drivers/staging/comedi/comedi_fops.c: In function 'comedi_mmap':
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: 'PAGE_SHARED' undeclared (first use in this function)
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: (Each undeclared identifier is reported only once
> > > > drivers/staging/comedi/comedi_fops.c:1453: error: for each function it appears in.)
> > > > make[3]: *** [drivers/staging/comedi/comedi_fops.o] Error 1
> > > 
> > > Odd.  What changed in the header files to cause this?
> > 
> > The problem has always been present, only now did randconfig find it.
> > The compile breaks because PAGE_SHARED is not defined for s390. The
> > equivalent define for s390 is PAGE_RW. The problem has not shown up so
> > far because all drivers who use the remap_pfn_range call with
> > PAGE_SHARED has dependencies not available on s390, e.g. CONFIG_PCI.
> > 
> > To fix this I see are two options: 1) add a PAGE_SHARED define to
> > arch/s390/include/asm/pgtable.h, 2) make comedi depend on !S390.
> 
> I'll drop s390 support for comedi, it doesn't make sense at all for that
> platform.
> 
> Actually, I'll just go off of PCI/ISA/USB/PCMCIA, that should drop s390
> automatically, right?

Correct.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/