linux-kernel - Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254995282.3713.18.camel@johannes.local>
Date:	Thu, 08 Oct 2009 11:48:02 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE

On Wed, 2009-10-07 at 17:12 -0700, Randy Dunlap wrote:

> > > # CONFIG_WIRELESS is not set
> > > CONFIG_WIRELESS_EXT=y
> > > CONFIG_WEXT_SPY=y
> > > CONFIG_WEXT_PRIV=y
> > > 
> > > WEXT_CORE is not enabled.  I haven't found the culprit, but I suspect "select".
> > 
> > Interesting.
> > 
> > > but what in WIRELESS_EXT would also cause WEXT_CORE to be enabled?
> > 
> > Well, the way WEXT_CORE is defined as def_bool y ought to, no?
> 
> Ah, I see what you mean.
> 
> Here's what's happening:
> 
> net/wireless/Kconfig says:
> 
> config WEXT_CORE
> 	def_bool y
> 	depends on CFG80211_WEXT || WIRELESS_EXT
> 
> 
> and net/Kconfig says:
> 
> if WIRELESS
> 
> source "net/wireless/Kconfig"
> source "net/mac80211/Kconfig"
> 
> endif # WIRELESS
> 
> 
> so WEXT_CORE actually depends on NET && WIRELESS && (CFG80211_WEXT || WIRELESS_EXT)
> (that's what xconfig shows me).
> But WIRELESS is not enabled.  Pooh.
> 
> I was already toying with making CONFIG_WIRELESS a real/usable kconfig symbol.
> That may have to be done unless someone else comes up with another solution.

Ah!

It's kinda strange though that you can select wireless drivers without
selecting WIRELESS. Maybe the solution is as simple as making WLAN
(drivers/net/wireless/Kconfig) depend on WIRELESS?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)