linux-kernel - Re: [RESEND PATCH] mce, edac: use an atomic notifier for MCEs decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091012103333.GB20051@elte.hu>
Date:	Mon, 12 Oct 2009 12:33:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Borislav Petkov <borislav.petkov@....com>
Cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RESEND PATCH] mce, edac: use an atomic notifier for MCEs
	decoding


* Borislav Petkov <borislav.petkov@....com> wrote:

> @@ -1420,6 +1428,10 @@ void __cpuinit mcheck_init(struct cpuinfo_x86 *c)
>  	mce_cpu_features(c);
>  	mce_init_timer();
>  	INIT_WORK(&__get_cpu_var(mce_work), mce_process_work);
> +
> +	if (raw_smp_processor_id() == 0)
> +		atomic_notifier_chain_register(&x86_mce_decoder_chain,
> +					       &mce_dec_nb);
>  }

this bit should be done in a cleaner way, by introducing a boot init 
function for MCE functionality.

(It's also broken if we boot on non-0 CPUs. Doesnt happen currently but 
still.)

Also, the function names there are pretty messy - please do another, 
rename patch that does something like:

  mcheck_init()       => mcheck_cpu_init()
  mce_init()          => __mcheck_cpu_init_generict()
  mce_cpu_features()  => __mcheck_cpu_init_vendor()
  mce_init_timer()    => __mcheck_cpu_init_timer()

etc.

I've applied your patch to x86/mce - please send delta patches to clean 
up the other aspects of it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/