linux-kernel - Re: [Regression, bisected] Transmit failure in et131x.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091012113629.4ed8e7f4@lxorguk.ukuu.org.uk>
Date:	Mon, 12 Oct 2009 11:36:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Nick Bowler <nbowler@...conx.ca>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Regression, bisected] Transmit failure in et131x.

> Thanks a lot for your help.  Alas, this does not resolve the issue.
> Using tcpdump indicates that receive continues to work while transmit
> fails.
> 
> I was using gigabit, but the problem persists when I run at 100mbit.
> The MTU setting remains at the default 1500 bytes.

et131x: Fix the add_10bit macro

From: Alan Cox <alan@...ux.intel.com>

Duh.. we need to preserve the wrap bit when adding.

Signed-off-by: Alan Cox <alan@...ux.intel.com>
---

 drivers/staging/et131x/et1310_address_map.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/staging/et131x/et1310_address_map.h b/drivers/staging/et131x/et1310_address_map.h
index 2273926..d71e04a 100644
--- a/drivers/staging/et131x/et1310_address_map.h
+++ b/drivers/staging/et131x/et1310_address_map.h
@@ -223,7 +223,7 @@ typedef union _TXDMA_PR_NUM_DES_t {
 
 extern inline void add_10bit(u32 *v, int n)
 {
-	*v = INDEX10(*v + n);
+	*v = INDEX10(*v + n) | (*v & ET_DMA10_WRAP);
 }
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/