linux-kernel - Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091012184739.46bb1052@i1501.lan.towertech.it>
Date:	Mon, 12 Oct 2009 18:47:39 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	Andrew Sharp <andy.sharp@....com>,
	Thomas Hommel <thomas.hommel@...anuc.com>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration

On Tue, 13 Oct 2009 01:37:40 +0900
Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:

> * Call dev_set_drvdata before rtc device creation
> * Use its own spinlock instead of rtc->irq_lock

 why?

> * Check pdata->rtc before calling rtc_update_irq
> * Use {alarm,update}_irq_enable and remove ioctl routine
> * Use devres APIs and simplify error/remove path

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/