linux-kernel - Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 02:04:15 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	alessandro.zummo@...ertech.it
Cc:	andy.sharp@....com, thomas.hommel@...anuc.com,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration

On Mon, 12 Oct 2009 18:47:39 +0200, Alessandro Zummo <alessandro.zummo@...ertech.it> wrote:
> > * Call dev_set_drvdata before rtc device creation
> > * Use its own spinlock instead of rtc->irq_lock
> 
>  why?

Because pdata->rtc must be initialized to use the irq_lock
(pdata->rtc->irq_lock).  There is a small window which rtc methods can
be called before pdata->rtc is initialized.

And there is no need use the irq_lock to protect hardware registers.
The driver's own spinlock shoule be enough.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/