linux-kernel - Re: [PATCH] kernel.h: Add a never optimized away pr_dbg for printk(KERN_DEBUG pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 21:28:31 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Joe Perches <joe@...ches.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel.h: Add a never optimized away pr_dbg for
 printk(KERN_DEBUG pr_fmt(fmt)...)

On Tue, 13 Oct 2009, Joe Perches wrote:

> > pr_dbg() is horribly misnamed, it doesn't indicate why it exists vs. 
> > pr_debug() at all.
> 
> Partially true, it's reasonably named because it's very short.
> 

It doesn't really matter how long it is if it doesn't accurately describe 
what it does.

> > I'd suggest pr_debug_force(), even though it's much longer (although still 
> > shorter than printk(KERN_DEBUG)).
> 
> pr_dbg allows longer format strings without exceeding 80 chars.
> 
> printk(KERN_DEBUG
> pr_debug_force
> pr_dbg_always
> pr_dbg_noopt
> 
> Other suggestions?
> 

The pr_dbg_* variations seem reasonable if the current pr_debug() were 
changed to pr_dbg().

I suggest converting some mainline code to use whatever you end up calling 
the !DEBUG variant, though, because this discussion is irrelevant if there 
are no current use cases (in which case the patch is pointless).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/