linux-kernel - Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910171654.03344.bzolnier@gmail.com>
Date:	Sat, 17 Oct 2009 16:54:03 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	John Linville <linville@...driver.com>,
	linux-wireless@...r.kernel.org, users@...x00.serialmonkey.com,
	Alban Browaeys <prahal@...oo.com>,
	Benoit PAPILLAULT <benoit.papillault@...e.fr>,
	Felix Fietkau <nbd@...nwrt.org>,
	Luis Correia <luis.f.correia@...il.com>,
	Mattias Nissler <mattias.nissler@....de>,
	Mark Asselstine <asselsm@...il.com>,
	Xose Vazquez Perez <xose.vazquez@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci


[ I somehow missed this one by not being on cc: ]

On Thursday 15 October 2009 22:04:14 Ivo van Doorn wrote:
> Add support for the rt2860/rt3090 chipsets from Ralink.
> 
> Includes various patches from a lot of people who helped
> getting this driver into the current shape.
> 
> Signed-off-by: Alban Browaeys <prahal@...oo.com>
> Signed-off-by: Benoit PAPILLAULT <benoit.papillault@...e.fr>
> Signed-off-by: Felix Fietkau <nbd@...nwrt.org>
> Signed-off-by: Luis Correia <luis.f.correia@...il.com>
> Signed-off-by: Mattias Nissler <mattias.nissler@....de>
> Signed-off-by: Mark Asselstine <asselsm@...il.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@...il.com>
> Signed-off-by: Ivo van Doorn <IvDoorn@...il.com>
> ---
> http://kernel.org/pub/linux/kernel/people/ivd/patches/0003-rt2x00-Implement-support-for-rt2800pci.patch

First let me say that I'm very happy to see this patch finally being
submitted and I appreciate the effort..

(I'll give it a spin on Eee 901 w/ 2.6.32-rc5 sometime later..)


Now to the less happy part..

I also used the opportunity to take a closer look at this driver and
it seems that it needlessly adds around 2 KLOC to kernel by duplicating
the common content of rt2800usb.h to rt2800pci.h instead of moving it
to the shared header (like it is done in the staging crap drivers):

$ wc -l drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h
  1951 drivers/net/wireless/rt2x00/rt2800usb.h
  1960 drivers/net/wireless/rt2x00/rt2800pci.h
  3911 total

$ diff -u drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h|diffstat
 rt2800pci.h |  213 +++++++++++++++++++++++++++++++-----------------------------
  1 file changed, 111 insertions(+), 102 deletions(-)

Similarly it looks like most of the code between rt2800usb.c and rt2800pci.c
could also be shared (up to another 2 KLOC saved) by adding abstraction layer
for accessing chipset registers over different buses (again like it is done
in staging crap drivers):

$ wc -l drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c
  3077 drivers/net/wireless/rt2x00/rt2800usb.c
  3323 drivers/net/wireless/rt2x00/rt2800pci.c
  6400 total

$ diff -u drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c|diffstat
 rt2800pci.c | 2190 +++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 1218 insertions(+), 972 deletions(-)

[ for better visualization of issues raised diffs themselves are available at:
  http://kernel.org/pub/linux/kernel/people/bart/rt2800/ ]

All in all, the total amount of the kernel code needed for implementing
rt2800pci functionality should 1-2 KLOC instead of the current 5 KLOC.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/