linux-kernel - Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255792104.3434.2.camel@johannes.local>
Date:	Sun, 18 Oct 2009 00:08:24 +0900
From:	Johannes Berg <johannes@...solutions.net>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Ivo van Doorn <ivdoorn@...il.com>,
	John Linville <linville@...driver.com>,
	linux-wireless@...r.kernel.org, users@...x00.serialmonkey.com,
	Alban Browaeys <prahal@...oo.com>,
	Benoit PAPILLAULT <benoit.papillault@...e.fr>,
	Felix Fietkau <nbd@...nwrt.org>,
	Luis Correia <luis.f.correia@...il.com>,
	Mattias Nissler <mattias.nissler@....de>,
	Mark Asselstine <asselsm@...il.com>,
	Xose Vazquez Perez <xose.vazquez@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci

On Sat, 2009-10-17 at 16:54 +0200, Bartlomiej Zolnierkiewicz wrote:

> I also used the opportunity to take a closer look at this driver and
> it seems that it needlessly adds around 2 KLOC to kernel by duplicating
> the common content of rt2800usb.h to rt2800pci.h instead of moving it
> to the shared header (like it is done in the staging crap drivers):

Tell me you're kidding -- comparing 2k duplicated LOC with a driver that
ships its own wifi stack?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)