linux-kernel - Re: [PATCH] power: pcf50633: introduces battery charging current control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091017170124.GB1526@ucw.cz>
Date:	Sat, 17 Oct 2009 19:01:24 +0200
From:	Pavel Machek <pavel@....cz>
To:	Paul Fertser <fercerpav@...il.com>
Cc:	Anton Vorontsov <cbou@...l.ru>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	Nelson Castillo <arhuaco@...aks-unidos.net>,
	Balaji Rao <balajirrao@...nmoko.org>
Subject: Re: [PATCH] power: pcf50633: introduces battery charging current
	control

Hi!

> From: Balaji Rao <balajirrao@...nmoko.org>

Could we get some changelog here? Like 'it adds new file to sysfs
interface, ...'



> +static ssize_t
> +show_chglim(struct device *dev, struct device_attribute *attr, char *buf)

Could we get meaningful function names?

> @@ -31,6 +31,8 @@ struct pcf50633_platform_data {
>  
>  	int charging_restart_interval;
>  
> +	int chg_ref_current_ma;
> +

...and variable names? This is also inconsistent with name above.

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/