linux-kernel - Re: [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910191559.38478.peter.ujfalusi@nokia.com>
Date:	Mon, 19 Oct 2009 15:59:38 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...ia.com>
To:	ext Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"tony@...mide.com" <tony@...mide.com>
Subject: Re: [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk

On Monday 19 October 2009 15:55:08 ext Mark Brown wrote:
> On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote:
> > +	apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
> > +	apll_ctrl &= ~TWL4030_APLL_INFREQ;
> >  	switch (freq) {
> 
> I'll apply this - it's idiomatic for the current driver - but you might
> want to look at snd_soc_update_bits() which does a read/modify/write
> cycle for you.
> 

Yeah, it is a good idea.
I'll address this when I go through the soc codec driver in my planned revisit 
and cleanup round quite soon.

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/