linux-kernel - Re: [patch 1/1] x86, UV: uv_hub_send_ipi Needs to set DELIVERY_MODE=4 for vector=NMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091019130821.GC9030@elte.hu>
Date:	Mon, 19 Oct 2009 15:08:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Robin Holt <holt@....com>
Cc:	tglx@...utronix.de, Jack Steiner <steiner@....com>,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	Martin Hicks <mort@....com>
Subject: Re: [patch 1/1] x86, UV: uv_hub_send_ipi Needs to set
	DELIVERY_MODE=4 for vector=NMI_VECTOR.


* Robin Holt <holt@....com> wrote:

> When sending a NMI_VECTOR IPI using the UV_HUB_IPI_INT register,
> we need to ensure the delivery mode field of that register has NMI
> delivery selected.
> 
> To: Ingo Molnar <mingo@...e.hu>
> To: tglx@...utronix.de
> Signed-off-by: Robin Holt <holt@....com>
> Acked-by: Jack Steiner <steiner@....com>
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...nel.org
> Cc: Martin Hicks <mort@....com>
> 
> ---
>  arch/x86/include/asm/uv/uv_hub.h |    6 ++++++
>  1 file changed, 6 insertions(+)
> Index: linux-x86/arch/x86/include/asm/uv/uv_hub.h
> ===================================================================
> --- linux-x86.orig/arch/x86/include/asm/uv/uv_hub.h	2009-10-19 04:07:07.000000000 -0500
> +++ linux-x86/arch/x86/include/asm/uv/uv_hub.h	2009-10-19 04:07:09.000000000 -0500
> @@ -19,6 +19,7 @@
>  #include <asm/types.h>
>  #include <asm/percpu.h>
>  #include <asm/uv/uv_mmrs.h>
> +#include <asm/irq_vectors.h>
>  
>  
>  /*
> @@ -435,9 +436,14 @@ static inline void uv_set_cpu_scir_bits(
>  static inline void uv_hub_send_ipi(int pnode, int apicid, int vector)
>  {
>  	unsigned long val;
> +	unsigned long dmode = 0; /* Directed Delivery */
> +
> +	if (vector == NMI_VECTOR)
> +		dmode = 4; /* NMI Delivery */
>  
>  	val = (1UL << UVH_IPI_INT_SEND_SHFT) |
>  			((apicid) << UVH_IPI_INT_APIC_ID_SHFT) |
> +			(dmode << UVH_IPI_INT_DELIVERY_MODE_SHFT) |
>  			(vector << UVH_IPI_INT_VECTOR_SHFT);
>  	uv_write_global_mmr64(pnode, UVH_IPI_INT, val);

Hm, would be cleaner to create an enum for that '4' (and for 0) in 
uv_mmrs.h and use it here. (We have similar constants for delivery modes 
in io_apic.h, see dest_*.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/