linux-kernel - Re: [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091019153816.GE3885@sortiz.org>
Date:	Mon, 19 Oct 2009 17:38:17 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Paul Fertser <fercerpav@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Nelson Castillo <arhuaco@...aks-unidos.net>
Subject: Re: [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on
 lowsys

Hi Paul,

I applied all patches except patch 5, on which I commented about.
Also, patch 3 didnt have any changelog execpt the SOB lines. I expect to get
something even for such trivial patches.

Thanks for your work.

Cheers,
Samuel.

On Wed, Oct 14, 2009 at 02:12:30AM +0400, Paul Fertser wrote:
> On gta02 hardware revision A5 it can actually bring the system down
> during normal operating conditions so we disable it.
> 
> Signed-off-by: Paul Fertser <fercerpav@...il.com>
> ---
>  drivers/mfd/pcf50633-core.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index d26d774..6efe5c3 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -345,6 +345,9 @@ static void pcf50633_irq_worker(struct work_struct *work)
>  		goto out;
>  	}
>  
> +	/* defeat 8s death from lowsys on A5 */
> +	pcf50633_reg_write(pcf, PCF50633_REG_OOCSHDWN,  0x04);
> +
>  	/* We immediately read the usb and adapter status. We thus make sure
>  	 * only of USBINS/USBREM IRQ handlers are called */
>  	if (pcf_int[0] & (PCF50633_INT1_USBINS | PCF50633_INT1_USBREM)) {
> -- 
> 1.6.0.6
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/