linux-kernel - Re: [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091019230952.GB19580@home.pavel.comp>
Date:	Tue, 20 Oct 2009 03:09:52 +0400
From:	Paul Fertser <fercerpav@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Nelson Castillo <arhuaco@...aks-unidos.net>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error
	handling

Hi Samuel,

Big thanks for your comments, next time i send anything upstream i
will certainly provide a minimal changelog for every patch :)

On Mon, Oct 19, 2009 at 05:08:13PM +0200, Samuel Ortiz wrote:
> On Wed, Oct 14, 2009 at 02:12:34AM +0400, Paul Fertser wrote:
> >  	if (enable_irq_wake(client->irq) < 0)
> > -		dev_err(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
> > +		dev_info(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
> >  			"in this hardware revision", client->irq);
> 2 things here: This doesnt really belong to this patch, and also I'd prefer to
> keep that as an error message.
[...]
> >  	ret = sysfs_create_group(&client->dev.kobj, &pcf_attr_group);
> >  	if (ret)
> > -		dev_err(pcf->dev, "error creating sysfs entries\n");
> > +		dev_info(pcf->dev, "Failed to create sysfs entries\n");
> Same here.

Sure. Please find amended version in attachement.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@...il.com

View attachment "0005-mfd-pcf50633-Cleanup-pcf50633_probe-error-handling.patch" of type "text/plain" (3511 bytes)