lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2009 09:26:52 +0200 From: Pavel Machek <pavel@....cz> To: Paul Fertser <fercerpav@...il.com> Cc: Anton Vorontsov <cbou@...l.ru>, David Woodhouse <dwmw2@...radead.org>, linux-kernel@...r.kernel.org, Nelson Castillo <arhuaco@...aks-unidos.net>, Balaji Rao <balajirrao@...nmoko.org> Subject: Re: [PATCH] power: pcf50633: introduces battery charging current control Hi! > > > @@ -31,6 +31,8 @@ struct pcf50633_platform_data { > > > > > > int charging_restart_interval; > > > > > > + int chg_ref_current_ma; > > > + > > > > ...and variable names? This is also inconsistent with name above. > > I added a comment explaining what this value is supposed to be set > to. The name is borrowed directly from the datasheet where it is > called "charger reference current". I hope this is ok. Can you call it "charging_reference_current_ma_" (or maybe charging_reference_ma, or something), then? You chave "charging_restart_interval" just above. Having both charging_ and chg_ prefixes is strange, and chg_ really does not hint at charging (I'd read it "change"). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists