linux-kernel - Re: [Patch] acerhdf: Return temperature in milidegree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2009 09:27:53 +0200
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Peter Feuerer <peter@...e.net>
Cc:	Borislav Petkov <petkovbb@...il.com>, linux-kernel@...r.kernel.org,
	Andreas Mohr <andi@...as.de>
Subject: Re: [Patch] acerhdf: Return temperature in milidegree

On Mon, Oct 19, 2009 at 11:11:07PM +0200, Peter Feuerer wrote:
> I just had a look at the documentation concerning this topic:
> 
> Documentation/thermal/sysfs-api.txt:162
> 
> temp           Current temperature as reported by thermal zone (sensor)
>            Unit: millidegree Celsius
>            RO
>            Required
> 
> 
> It is expected to be in millidegree, so I think we should discuss,
> modify and apply the patch.

Well well, looka here, it is an interface! I guess the temperature has
to be in millidegrees for better granularity or similar. Now userspace
has to do temp / 1000.0 and so on.

In that case, the patch should be applied. I'll give it a run later.

Minor nitpick: Add the sysfs-api requirement to the commit message
instead of "userspace applications."

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/