linux-kernel - Re: [Patch] acerhdf: Return temperature in milidegree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2009 07:25:47 +0200
From:	Andreas Mohr <andi@...as.de>
To:	Peter Feuerer <peter@...e.net>
Cc:	Andreas Mohr <andi@...as.de>, Borislav Petkov <petkovbb@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch] acerhdf: Return temperature in milidegree

Hi,

On Mon, Oct 19, 2009 at 11:24:47PM +0200, Peter Feuerer wrote:
> I agree with you in these points, but I have also some disadvantages to discuss:
>
> Disadvantages:
> - Thinking about the implemenation such a macro would require, users may  
>   get confused. They would still set the fanon / fanoff trip points in   
> degree, but when they read documentation or the current temperature,   
> millidegree is used.  - I think "TEMP_DEGREE_TO_SYS(59)" in code is not   
> as good readable as "59000"
>
> what about writing something like "59 * 1000" insead of "59000"?
>
> Or something like that:
>
> #define FACTOR_MILLIDEGREE 1000
> 59 * FACTOR_MILLIDEGREE 
>
> this solution has all your listed advantages and eliminates the  
> disadvantages I see in the "TEMP_DEGREE_TO_SYS" solution.

Well, yes, much better, in fact TEMP_DEGREE_TO_SYS is simple overengineering
(using a generic, _cryptic_ name in order to keep using it in the somewhat unlikely
case of having the factor change when you could just as well have mass-renamed
the couple places that use the macro name)

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/