lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <36176.167.216.14.194.1256001083.squirrel@www.concentris-systems.com> Date: Mon, 19 Oct 2009 15:11:23 -1000 (HST) From: "Scott Valentine" <svalentine@...centris-systems.com> To: rtc-linux@...glegroups.com Cc: a.zummo@...ertech.it, raph@...com, linux-kernel@...r.kernel.org Subject: [PATCH] RTC: v3020 driver bugfix v3020 read_bit always returns 0 when left_shift > 7 The v3020 read_bit function's return type is (unsigned char). The code returns a value masked by (1 << left_shift) that is casted to the return type. If left_shift is larger than 7, the cast will always result in a 0 return value. The problem was discovered with left_shift = 16, and the included patch corrects the problem. The bug was introduced in the last (Apr 3 2009) commit of the file, kernel versions 2.6.30 and later. diff -uNr a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c --- a/drivers/rtc/rtc-v3020.c 2009-10-15 14:41:50.000000000 -1000 +++ b/drivers/rtc/rtc-v3020.c 2009-10-19 14:06:27.000000000 -1000 @@ -96,7 +96,7 @@ static unsigned char v3020_mmio_read_bit(struct v3020 *chip) { - return readl(chip->ioaddress) & (1 << chip->leftshift); + return ((readl(chip->ioaddress) & (1 << chip->leftshift)) != 0); } static struct v3020_chip_ops v3020_mmio_ops = { Scott Valentine Concentris Systems LLC Manoa Innovation Center, Suite #238 2800 Woodlawn Drive Honolulu, HI 96822 http://www.Concentris-Systems.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists