linux-kernel - Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AE218A5.5070008@gmail.com>
Date:	Sat, 24 Oct 2009 00:57:09 +0400
From:	Alexey Starikovskiy <aystarik@...il.com>
To:	Ike Panhc <ike.pan@...onical.com>
CC:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexandre Rostovtsev <tetromino@...il.com>,
	Corentin CHARY <corentincj@...aif.net>
Subject: Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

Hi Ike,

I'm sorry to say this, bit it looks like your design is seriously 
flowed. Not any ACPI device should
require interception of EC query events.

You should register device for HID "ATK0101" and get all notifications 
there, as it is done for
for ASUS ATK0100 hot key driver (drivers/platform/x86/asus-laptop.c), 
and I would guess,
that driver for ASUS ATK0101 hot key driver may be either an extension 
to ATK0100 driver
or based on it, if new device does not share any events.
This would be real solution, and not a hack for a single notebook/BIOS 
version.
 From the DSDT it is obvious that _Q numbers are not permanent and could 
change even
with the next BIOS revision.

You may also contact current maintainer of asus-laptop driver, Corentin 
Chary, as he might help you with design.

Regards,
Alex.

Ike Panhc пишет:
> Hi Alex,
>
> The attachment is the acpidump.
>
> I register for EC query events because it is an event source of hotkey
> press
>
> Alexey Starikovskiy wrote:
>   
>> Hi,
>>
>> Could you please post acpidump from this machine, I would like to
>> understand,
>> why you need to register for EC query events.
>>
>> Thanks,
>> Alex.
>>
>>     
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/