linux-kernel - Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200910231543.12254.bjorn.helgaas@hp.com>
Date:	Fri, 23 Oct 2009 15:43:10 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Ike Panhc <ike.pan@...onical.com>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexandre Rostovtsev <tetromino@...il.com>
Subject: Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

On Friday 23 October 2009 01:11:48 pm Ike Panhc wrote:

> +static int __init lenovo_sl_laptop_init(void)
> +{
> +	int ret;
> +	acpi_status status;
> +
> +	if (acpi_disabled)
> +		return -ENODEV;

Don't need this.

> +	lenovo_sl_laptop_hkey_handle = lenovo_sl_laptop_ec0_handle = NULL;
> +	status = acpi_get_handle(NULL, ACPI_HKEY_PATH,
> +				 &lenovo_sl_laptop_hkey_handle);
> +	if (ACPI_FAILURE(status)) {
> +		pr_err("Failed to get ACPI handle for %s\n", ACPI_HKEY_PATH);
> +		return -ENODEV;
> +	}

Don't need this; acpi_bus_register_driver() is enough.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/