linux-kernel - [PATCH -tip] sched: Use root_task_group_empty only with FAIR_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091026192414.GB5321@lenovo>
Date:	Mon, 26 Oct 2009 22:24:14 +0300
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH -tip] sched: Use root_task_group_empty only with
	FAIR_GROUP_SCHED

Please review. Perhaps there some usage planned in future?

	-- Cyrill
---
root_task_group_empty is used only with
FAIR_GROUP_SCHED so if we use other scheduler
we get

kernel/sched.c:314: warning: ‘root_task_group_empty’ defined but not used

So move CONFIG_FAIR_GROUP_SCHED up that it cover
root_task_group_empty.

Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
---
 kernel/sched.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.git/kernel/sched.c
=====================================================================
--- linux-2.6.git.orig/kernel/sched.c
+++ linux-2.6.git/kernel/sched.c
@@ -309,6 +309,8 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(str
  */
 static DEFINE_SPINLOCK(task_group_lock);
 
+#ifdef CONFIG_FAIR_GROUP_SCHED
+
 #ifdef CONFIG_SMP
 static int root_task_group_empty(void)
 {
@@ -316,7 +318,6 @@ static int root_task_group_empty(void)
 }
 #endif
 
-#ifdef CONFIG_FAIR_GROUP_SCHED
 #ifdef CONFIG_USER_SCHED
 # define INIT_TASK_GROUP_LOAD	(2*NICE_0_LOAD)
 #else /* !CONFIG_USER_SCHED */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/