linux-kernel - Re: 2.6.32-rc1: spurious error message from "ACPI button: provide lid status functions"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091026132420.2f639966@jbarnes-g45>
Date:	Mon, 26 Oct 2009 13:24:20 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
Cc:	Eric Anholt <eric@...olt.net>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	linux acpi <linux-acpi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, lenb@...nel.org
Subject: Re: 2.6.32-rc1: spurious error message from "ACPI button: provide
 lid status functions"

On Sat, 03 Oct 2009 11:52:57 +0100
Alan Jenkins <alan-jenkins@...fmail.co.uk> wrote:

> ACPI: Waking up from system sleep state S4
> PM: Device PNP0C0D:00 failed to thaw: error 1
> 
> The device appears to be the acpi lid "button".  The error comes from
> calling acpi_lid_send_state():
> 
>     @@ -242,7 +272,12 @@ static int acpi_lid_send_state(struct
>     acpi_device *device)
>          /* input layer checks if event is redundant */
>          input_report_switch(button->input, SW_LID, !state);
>          input_sync(button->input);
>     -    return 0;
>     +
>     +    ret = blocking_notifier_call_chain(&acpi_lid_notifier, state,
>     device);
>     +    if (ret == NOTIFY_DONE)
>     +        ret = blocking_notifier_call_chain(&acpi_lid_notifier,
> state,
>     +                           device);
>     +    return ret;
>      }
> 
> 
> The "error 1" is actually NOTIFY_OK.
> 
>     @include/linux/notify.h:
>     #define NOTIFY_DONE        0x0000        /* Don't care */
>     #define NOTIFY_OK        0x0001        /* Suits me */
>     #define NOTIFY_STOP_MASK    0x8000        /* Don't call further */
>     #define NOTIFY_BAD        (NOTIFY_STOP_MASK|0x0002)
>                             /* Bad/Veto action */
>     /*
>      * Clean way to return from the notifier and stop further calls.
>      */
>     #define NOTIFY_STOP        (NOTIFY_OK|NOTIFY_STOP_MASK)
> 
> 
> Clearly acpi_lid_send_state() should return 0 for NOTIFY_OK.  I guess
> NOTIFY_STOP can be ignored until someone says they need it.
> 
> But I don't understand the NOTIFY_DONE case, so I'm not sure.  I can't
> find any users to reverse engineer it.  IMO it either needs to be
> removed or commented.
> 
> Can you please sort this out, so we don't see this error message on a
> completely successful resume?

I think Len and I sorted this out at KS.  Len did you commit the fix
suggested above?

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/