linux-kernel - [PATCH -tip] irq: Do not attempt to create subdirectories if /proc/irq/<irq> failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091026202811.GD5321@lenovo>
Date:	Mon, 26 Oct 2009 23:28:11 +0300
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Yinghai Lu <yinghai@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH -tip] irq: Do not attempt to create subdirectories if
	/proc/irq/<irq> failed

If a parent directory (ie /proc/irq/<irq>) could not be created
we should not attempt to create subdirectories. Otherwise it would
lead that "smp_affinity" and "spurious" entries are may be registered
under /proc root instead of a proper place.

Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
---

Please review. This is not critical even if will be failing
at this point even at every call but better to be sure all
goe fine. I hope I don't miss anything?

 kernel/irq/proc.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6.git/kernel/irq/proc.c
=====================================================================
--- linux-2.6.git.orig/kernel/irq/proc.c
+++ linux-2.6.git/kernel/irq/proc.c
@@ -214,6 +214,8 @@ void register_irq_proc(unsigned int irq,
 
 	/* create /proc/irq/1234 */
 	desc->dir = proc_mkdir(name, root_irq_dir);
+	if (!desc->dir)
+		return;
 
 #ifdef CONFIG_SMP
 	/* create /proc/irq/<irq>/smp_affinity */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/