lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2009 13:53:41 -0700 From: "Darrick J. Wong" <djwong@...ibm.com> To: Jean Delvare <khali@...ux-fr.org> Cc: Crane Cai <crane.cai@....com>, Bjorn Helgaas <bjorn.helgaas@...com>, lenb@...nel.org, linux-kernel <linux-kernel@...r.kernel.org>, linux-i2c@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [PATCH 2/2] acpi: support IBM SMBus CMI devices On Sun, Oct 25, 2009 at 12:53:53PM +0100, Jean Delvare wrote: > > + else if (!probe_ibm_smbus_device(device)) > > + acpi_add_id(device, ACPI_SMBUS_IBM_HID); > > I am not responsible for the ACPI code, but... wouldn't it make sense > to rename probe_ibm_smbus_device() to acpi_ibm_smbus_match() and have > it follow the same convention as acpi_dock_match() and > acpi_bay_match()? To make the code more consistent. Sure. > > + {ACPI_SMBUS_IBM_HID, (kernel_ulong_t)&ibm_smbus_methods}, > > As both patches depend on each other and one is useless without the > other, you might as well sequence them the other way around, so that > you touch this line only once. Will do. > Other that these details, I like the patch. If this helps with ACPI > resource conflicts, even better :) It should. :) I'll reroll the patch set shortly. --D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists