linux-kernel - Re: staging/dream: add gpio and pmem support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091027165750.GA24477@kroah.com>
Date:	Tue, 27 Oct 2009 09:57:50 -0700
From:	Greg KH <greg@...ah.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Arve Hj?nnev?g <arve@...roid.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Brian Swetland <swetland@...gle.com>
Subject: Re: staging/dream: add gpio and pmem support

On Tue, Oct 27, 2009 at 09:19:21AM +0100, Pavel Machek wrote:
> On Mon 2009-10-26 20:00:39, Greg KH wrote:
> > On Tue, Oct 27, 2009 at 01:17:03AM +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > > This adds generic_gpio and pmem support, both are needed for other
> > > > > dream drivers.
> > > > > 
> > > > > Signed-off-by: Pavel Machek <pavel@....cz>
> > > > 
> > > > I'd prefer to get the existing code building, before adding new stuff :(
> > > 
> > > Well, unfortunately other pieces depend on these.
> > 
> > The pieces already in the tree? 
> 
> Yes :-(.
> 
> > Why are you sending me patches that do
> > not build?
> 
> I did not realize how much was those drivers depenend on arch-specific part.
> 
> > > I have it building with this patch (but note that it uses -I magic; I
> > > started to write script rewriting files so that -I is not neccessary,
> > > but I did not have time to finish it yet).
> > 
> > Ok, should I just delete the whole drivers/staging/dream/ directory as
> > there seems no goal to get this to build properly?  I've just marked the
> > code as BROKEN, any chance to get it building again soon?
> 
> Could we perhaps use -I to let it build before I find time to do
> search&replace of 100 #includes? Yes, I'm working on that, but no, it
> obviously does not progress as fast as I expected...
> 
> 								Pavel
> 
> Add missing files/includes neccessary for Dream compilation.
>     
> Signed-off-by: Pavel Machek <pavel@....cz>

Ick, no.  I'm not going to take the wakelock and other header files that
are "generic" to android into the dream subdir.  That's not ok.

If this code requires this mess to build, I think we should just delete
the whole thing and start over with patches that add code that can
actually build properly.

Any objection to that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/