linux-kernel - Re: [PATCH 3/7] Documentation: ABI: /sys/devices/system/cpu/ topology files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091028212312.GH22743@ldl.fc.hp.com>
Date:	Wed, 28 Oct 2009 15:23:12 -0600
From:	Alex Chiang <achiang@...com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Travis <travis@....com>, linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 3/7] Documentation: ABI: /sys/devices/system/cpu/
	topology files

* David Rientjes <rientjes@...gle.com>:
> On Wed, 21 Oct 2009, Alex Chiang wrote:
> 
> > diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> > index 86126b1..871acdb 100644
> > --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> > +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> > @@ -10,6 +10,34 @@ Description:
> >  		/sys/devices/system/cpu/cpu#/
> >  
> >  
> > +What:		/sys/devices/system/cpu/kernel_max
> > +		/sys/devices/system/cpu/offline
> > +		/sys/devices/system/cpu/online
> > +		/sys/devices/system/cpu/possible
> > +		/sys/devices/system/cpu/present
> > +Date:		December 2008
> > +Contact:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
> > +Description:	CPU topology files that describe kernel limits related to
> > +		hotplug. Briefly:
> > +
> > +		kernel_max: the maximum cpu index allowed by the kernel
> > +		configuration.
> > +
> > +		offline: cpus that are not online because they have been
> > +		HOTPLUGGED off or exceed the limit of cpus allowed by the
> > +		kernel configuration (kernel_max above).
> > +
> > +		online: cpus that are online and being scheduled.
> > +
> > +		possible: cpus that have been allocated resources and can be
> > +		brought online if they are present.
> > +
> > +		present: cpus that have been identified as being present in
> > +		the system.
> > +
> > +		See Documentation/cputopology.txt for more information.
> > +
> > +
> >  What:      /sys/devices/system/cpu/cpu*/cache/index*/cache_disable_X
> >  Date:      August 2008
> >  KernelVersion:	2.6.27
> 
> I noticed that this and patches 4-6 were added to gregkh-2.6.  Alex, did 
> you want to seperate these large multi-file sections into individual file 
> sections so that it is consistent with the remainder of Documentation/ABI?

That's one option. Here's another:

> > +What:		/sys/devices/system/cpu/kernel_max
> > +What:		/sys/devices/system/cpu/offline
> > +What:		/sys/devices/system/cpu/online
> > +What:		/sys/devices/system/cpu/possible
> > +What:		/sys/devices/system/cpu/present

That way, your grep that you displayed in another mail still
works.

I understand the point about consistency, but... I kinda like the
condensed format better, since imho, it's easier to read.

Dunno, I don't have very strong feelings really... Greg already
took them, so David, if you do have a strong feeling, let me know
and I'll ask Greg to drop and I'll do one last respin.

Thanks,
/ac
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/