linux-kernel - Re: [PATCH 3/7] Documentation: ABI: /sys/devices/system/cpu/ topology files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Oct 2009 01:44:11 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Alex Chiang <achiang@...com>
cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Travis <travis@....com>, linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 3/7] Documentation: ABI: /sys/devices/system/cpu/ topology
 files

On Wed, 28 Oct 2009, Alex Chiang wrote:

> > I noticed that this and patches 4-6 were added to gregkh-2.6.  Alex, did 
> > you want to seperate these large multi-file sections into individual file 
> > sections so that it is consistent with the remainder of Documentation/ABI?
> 
> That's one option. Here's another:
> 
> > > +What:		/sys/devices/system/cpu/kernel_max
> > > +What:		/sys/devices/system/cpu/offline
> > > +What:		/sys/devices/system/cpu/online
> > > +What:		/sys/devices/system/cpu/possible
> > > +What:		/sys/devices/system/cpu/present
> 
> That way, your grep that you displayed in another mail still
> works.
> 
> I understand the point about consistency, but... I kinda like the
> condensed format better, since imho, it's easier to read.
> 
> Dunno, I don't have very strong feelings really... Greg already
> took them, so David, if you do have a strong feeling, let me know
> and I'll ask Greg to drop and I'll do one last respin.
> 

When I originally saw the format that the Documentation/ABI files were 
written in, I had this premonition that someone would eventually write a 
gui application that allowed users to tune their sysfs files and that it 
would inevitably include commentary on what the file represented by using 
the documentation.  It was easily parsable and had a strict file naming 
scheme that this was possible.  It seems we've departed from that at a 
relatively late stage in its maturity with no real benefit, but I'll defer 
to the maintainer's preference.

Regardless, thanks a lot for documenting these files and going the extra 
mile!  I'm sure it will come in very useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/