linux-kernel - Re: [PATCH] Fix generic_block_fiemap for files bigger than 4GB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091029151945.GA453@glandium.org>
Date:	Thu, 29 Oct 2009 16:19:45 +0100
From:	Mike Hommey <mh@...ndium.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Josef Bacik <josef@...hat.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Steven Whitehouse <swhiteho@...hat.com>,
	Theodore Ts'o <tytso@....edu>,
	Eric Sandeen <sandeen@...hat.com>,
	Josef Bacik <jbacik@...hat.com>, Mark Fasheh <mfasheh@...e.com>
Subject: Re: [PATCH] Fix generic_block_fiemap for files bigger than 4GB

On Thu, Oct 29, 2009 at 08:17:01AM -0700, Andrew Morton wrote:
> > -	struct buffer_head tmp;
> > -	unsigned int start_blk;
> > -	long long length = 0, map_len = 0;
> > +	struct buffer_head map_bh;
> > +	sector_t start_blk;
> 
> And the bugfix is there.
> 
> Has anyone actually tested this code on large files?  Greater than 4G
> sectors and greater than 4G pages?
> 

I tested my patch with 2TB sparse files that would fail without the patch.

I can give a try to Josef's patch if that's necessary.

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/