linux-kernel - Re: [PATCH 1/3] Fix updating of named attribute groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Oct 2009 10:19:08 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Tejun Heo <teheo@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/3] Fix updating of named attribute groups

On Thu, Oct 29, 2009 at 04:59:02PM +0100, Tejun Heo wrote:
> Matthew Wilcox wrote:
> > +		if (update) {
> > +			sd = sysfs_get_dirent(kobj->sd, grp->name);
> > +			if (!sd)
> > +				return -ENOENT;
> > +		} else {
> > +			error = sysfs_create_subdir(kobj, grp->name, &sd);
> > +			if (error)
> > +				return error;
> > +			sysfs_get(sd);
> > +		}
> > +	} else {
> > +		sd = sysfs_get(kobj->sd);
> > +	}
> 
> nitpick: the last braces aren't necessary.

But are more aesthetically pleasing.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/